Highlight when tabbing to umb-toggle #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DennisRP! A big thank you and congratulations on your first PR to this repo! One of us will take a look at the work and let you know if we need anything further from you. When we merge, you'll get a new badge on your our.umbraco.com profile. All the best! Emma, Pull Request team |
|
Hey there @DennisRP ! What a lovely little update there, makes it much clearer you're on a toggle indeed. And this is your first PR as well, great work!! Check out that cool new Contributor badge on your Our Umbraco profile! https://our.umbraco.com/members/id:12505/ 🎖 Ps. I made an educated guess that this was your profile, let me know if the badge needs to be applied to a different one. Thanks again, looking forward to more contributions from your hand! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #5277 (Possibly part of)
Description
It is very vague when tabbing to a toggle component (on/off) to see it was selected. Very contradictive to tab-outlines of other components.
Fixed by hooking in the same active-tabbing state as other components