Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Accessibility improvements: Screen Reader Prerequisites #5705

Closed
wants to merge 4 commits into from
Closed

V8: Accessibility improvements: Screen Reader Prerequisites #5705

wants to merge 4 commits into from

Conversation

RachBreeze
Copy link
Contributor

A number of accessibility issues have been identified in #5277.
Many of the fixes require a class which supports hidden text for screen readers.

The aim of this PR is to start to build the css elements which the screen readers will require.

A number of PRs have already been submitted which require a screen reader only class #5544, #5585 and #5664

Following a review of #5664 we identified the need to submit an individual PR for a screen reader only class. The aim of this PR is to allow the class to be pulled into belle.less independently of the other PRs allowing the accessibility work to continue whilst the other PRs are reviewed.

@emmaburstow
Copy link
Contributor

Hi Rachel!

Thanks for this PR. It looks great and will really improve accessibility. Will let you know if we need any changes.

Em

@RachBreeze
Copy link
Contributor Author

Good morning @emmaburstow
Thank you. Would it be possible for you to tag this with the accessibility label please?
Cheers

@emmaburstow
Copy link
Contributor

Sure :)

@zersiax
Copy link
Contributor

zersiax commented Jun 25, 2019

Looks good, it was a good idea to use Bootstrap's example here. There's a number of elements a class like this would be useful for, most notably a place to fire aria live alerts from. Adding extra explanatory text to visual controls is another use, but try not to go too crazy with the verbosity when it comes to that. "This button opens a menu that lets you change the universe in very interesting ways" is too long and would be read out every single time a screen reader lands on the element in question :-)

@nul800sebastiaan
Copy link
Member

Thanks @RachBreeze - this was already merged as part of #5664 - great job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants