V8: Add validation to the Version and UmbracoVersion properties #5559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a Package in the Umbraco backoffice.
Mivaweb
changed the title
nul800sebastiaan
requested changes
Jun 3, 2019
There was a problem hiding this comment.
Thanks @Mivaweb - Can you update with the version number requirement to always have 3 parts please?
src/Umbraco.Web.UI.Client/src/views/packages/edit.controller.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
See issue 5528: V8 - Install local package gives error: incorrect version
Description
We need to help the user when entering a version for his package and which umbraco version it uses. For the package version we can enter v1.0.0 which results in an error when installing the package in Umbraco in the backoffice.
So, we added 2 regular expressions in the edit package controller: