Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Accessibility improvements for top header #5544

Merged
merged 6 commits into from
Jun 23, 2019
Merged

V8: Accessibility improvements for top header #5544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
079de01
feat: add btn-reset class to reset default browser button styles.
MMasey May 29, 2019
40d0316
fix: update app-header buttons to use HTML button element
MMasey May 29, 2019
eb5cbca
feat: add visually-hidden class
MMasey May 29, 2019
f186d9a
feat: add visually-hidden class to belle.less
MMasey May 29, 2019
b847218
fix: add labels to app header buttons
MMasey May 29, 2019
4099a90
Merge branch 'v8/dev' into v8/bugfix/fix-top-menu-button-markup
MMasey Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Umbraco.Web.UI.Client/src/less/accessibility/visually-hidden.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

// Visually Hidden - used to remove an element from the view, whilst retaining accessibily for screen readers. More info available at https://a11yproject.com/posts/how-to-hide-content/
// --------------------------------------------------

.visually-hidden {
position: absolute !important;
height: 1px;
width: 1px;
overflow: hidden;
clip: rect(1px, 1px, 1px, 1px);
}
3 changes: 3 additions & 0 deletions src/Umbraco.Web.UI.Client/src/less/belle.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@

@import "forms/umb-validation-label.less";

// Umbraco Accessibility
@import "accessibility/visually-hidden.less";

// Umbraco Components
@import "components/application/umb-app-header.less";
@import "components/application/umb-app-content.less";
Expand Down
15 changes: 15 additions & 0 deletions src/Umbraco.Web.UI.Client/src/less/buttons.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,21 @@
border-color: rgba(0,0,0,0.09);
}

// Button Reset - remove the default browser styles from the button element
// --------------------------------------------------

.btn-reset {
padding: 0;
margin: 0;
border: none;
background: none;
color: currentColor;
font-family: @baseFontFamily;
font-size: @baseFontSize;
line-height: @baseLineHeight;
cursor: pointer;
}

// Button Sizes
// --------------------------------------------------

Expand Down
15 changes: 7 additions & 8 deletions src/Umbraco.Web.UI.Client/src/less/components/application/umb-app-header.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,26 @@
margin-right: -10px;
}

.umb-app-header__action a {
.umb-app-header__button {
padding-left: 10px;
padding-right: 10px;
text-decoration: none;
display: flex;
align-items: center;
height: @appHeaderHeight;
}

.umb-app-header__action a {
outline: none;

&:focus {
.tabbing-active & {
.umb-app-header__action-icon::after {
content: '';
position: absolute;
z-index:10000;
top: -7px;
left: -7px;
top: 50%;
left: 50%;
width: 36px;
height: 35px;
transform: translate(-50%, -50%);
border-radius: 3px;
box-shadow: 0 0 2px @pinkLight, inset 0 0 2px 1px @pinkLight;
}
Expand All @@ -51,7 +50,7 @@
font-size: 22px;
}

.umb-app-header__action a:hover .umb-app-header__action-icon,
.umb-app-header__action a:focus .umb-app-header__action-icon {
.umb-app-header__button:hover .umb-app-header__action-icon,
.umb-app-header__button:focus .umb-app-header__action-icon {
opacity: 1;
}
16 changes: 10 additions & 6 deletions src/Umbraco.Web.UI.Client/src/views/components/application/umb-app-header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

<div>

<div class="umb-app-header">
Expand All @@ -10,25 +11,28 @@
<div class="flex items-center">
<ul class="umb-app-header__actions">
<li data-element="global-search" class="umb-app-header__action">
<a href="#" hotkey="ctrl+space" ng-click="searchClick()" ng-mousedown="rememberFocus()" prevent-default style="font-size: 20px;">
<button class="umb-app-header__button btn-reset" hotkey="ctrl+space" ng-click="searchClick()" ng-mousedown="rememberFocus()" prevent-default style="font-size: 20px;">
<span class="visually-hidden">Open/Close backoffice search</span>
<i class="umb-app-header__action-icon icon-search"></i>
</a>
</button>
</li>
<li data-element="global-help" class="umb-app-header__action">
<a href="#" hotkey="ctrl+shift+h" ng-click="helpClick()" prevent-default>
<button class="umb-app-header__button btn-reset" hotkey="ctrl+shift+h" ng-click="helpClick()" prevent-default>
<span class="visually-hidden">Open/Close backoffice help window</span>
<i class="umb-app-header__action-icon icon-help-alt"></i>
</a>
</button>
</li>
<li data-element="global-user" class="umb-app-header__action">
<a href="#" hotkey="ctrl+shift+u" ng-click="avatarClick()" prevent-default title="{{user.name}}" >
<button class="umb-app-header__button btn-reset" ng-click="avatarClick()" hotkey="ctrl+shift+u" title="{{user.name}}" aria-label="Open/Close your profile options window" prevent-default>
<umb-avatar
class="umb-app-header__action-icon"
size="xxs"
color="secondary"
name="{{user.name}}"
img-src="{{avatar[0].value}}"
img-srcset="{{avatar[1].value}} 2x, {{avatar[2].value}} 3x">
</umb-avatar>
</a>
</button>
</li>
</ul>
</div>
Expand Down