Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu items have insufficient focus (tab) states #5458

Merged
merged 2 commits into from
May 31, 2019
Merged

Menu items have insufficient focus (tab) states #5458

merged 2 commits into from
May 31, 2019

Conversation

tiffy74
Copy link
Contributor

@tiffy74 tiffy74 commented May 14, 2019

Prerequisites

This is to fix issue #5277 Number 13

Description

Issue is about visible focus states of the top menu navigation.

Edited the sections.less file, removed the focus state from opacity and added border styling

**nb if you would prefer different styling for the border - I removed the pinklight box shadow and replaced it for a simple grey border as I thought it looked a bit ugly - just let me know

@emmaburstow
Copy link
Contributor

Hey @tiffy74

Thanks for the work here :)

We'll take a look and let you know if we need anything else from you.

Em

@nul800sebastiaan
Copy link
Member

Well isn't that lovely @tiffy74 !! 👍

Congratulations on your first accepted PR for Umbraco CMS, we're looking forward to many more wonderful contributions.

And would you look at that shiny new contributor badge on your Our profile! 🎉 https://our.umbraco.com/members/id:271783/ 🎖

@nul800sebastiaan nul800sebastiaan changed the title Issue#5277 13 Menu items have insufficient focus (tab) states May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants