Re-adding focus states for the .umb-tree links #5334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Hi @shane-sigma Thanks for fixing this accessibility issue, I though see that we would need to make it more pretty and align these focus outlines across the project, therefor I have created a CSS-class called umb-outline that can be used to apply a umbraco outline look. Only appearing when the user is tabbing. Part of my PR is to addthe umb-outline to the tree, therefor I will close this one. And it will then be looking like this: I thought think we need to enable more features in the tree for keyboard navigation, like: Open/collapse and the actions dialog button. But thats another task. See the PR here: #5337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Related to #2577 accessibility bug number 19
No focus (tab) state present for the content tree items, have removed the outline:0 rule.