Re-adding outline to the umb-button__button for focus states #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Hey @shane-sigma , Congratulations on your first PR! We shall review it and get back to you if we need anything more. Once this PR gets approved and merged you will have your shiny Contributor badge on your Our.Umbraco profile. 👍 Poornima |
warrenbuckley
approved these changes
Apr 24, 2019
…ient folder anyway
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
This is in relation to the accessibility issues on ticket #5277 - Bug number 4 from the table
Description
Bottom publishing options ('Preview', 'Save', 'Save and publish') have insufficient focus (tab) state
I have removed the CSS that prevented the browser default outline from showing on these buttons