Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Send notifications for changes in permissions #5287

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Apr 17, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

You can subscribe to notifications for changes in content permissions. Unfortunately these notifications are never sent.

This PR fixes that.

Testing this PR

  1. Create two users - A and B.
  2. Subscribe user A to the permissions event on a content item
  3. Let user B change the permissions for the content item, e.g. alter the "Editor" role permissions. Verify that user A is notified about it.
  4. Let user B undo the changes made, and verify that user A is notified about it.

Hint: This SMTP configuration might make testing a bit easier 😄

<smtp from="[email protected]" deliveryMethod="SpecifiedPickupDirectory">
  <specifiedPickupDirectory pickupDirectoryLocation="Path\To\Site\Root\App_Data\MailDump" />
</smtp>

@emmaburstow
Copy link
Contributor

Excellent description as usual! Thanks Kenn, speak soon,

Em

# Conflicts:
#	src/Umbraco.Web/Compose/NotificationsComponent.cs
@nul800sebastiaan
Copy link
Member

👍

@kjac kjac deleted the v8-fix-notifications-permissions branch April 23, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants