V8: Updated Constant.System.Root references (to use correct constant, and others) #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to use the `System.RootString` constant. This saves on integer parsing and reduces the number of new strings being created. Since the `System.Root` is `-1`, it didn't need the culture invariant conversion.
to use the `System.RecycleBinContentString` constant. This saves on integer parsing and reduces the number of new strings being created. Since the `System.RecycleBinContentString` is `-20`, it didn't need the culture invariant conversion.
to use the `System.RecycleBinMediaString` constant. This saves on integer parsing and reduces the number of new strings being created. Since the `System.RecycleBinMedia` is `-21`, it didn't need the culture invariant conversion.
Also removed unused namespaces.
ghost
assigned 
leekelleher
changed the title
|
@warrenbuckley if you get a chance could you have a quick look? Looks like a great and easy change. If/when you merge please flag for 8.1 release |
|
Code changes look fine. Azure DevOps built this against V7 for some reason. https://umbraco.visualstudio.com/Umbraco%20Cms/_build/results?buildId=19632 |
|
All passed & code reads fine - merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixesDescription
I'd noticed there were several
Constants.System.Root.ToInvariantString()calls, (e.g. to convert theintto astring), but there is an existingConstants.System.RootStringconstant (string). So I've swapped them over.This should reduce the number of string conversions / new allocations. A teeny-weeny CPU/memory improvement. 😉
I also did the
Constants.System.RecycleBinContentandConstants.System.RecycleBinMediareferences too.I've re-ran all the unit-tests in Visual Studio, all passed - and checked the CMS back-office, navigated around the content section.
I wouldn't say that I've done extensive testing against an existing/populated Umbraco instance, since this felt like a low-risk code change.