Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed LESS variables with disgrete to discreet #4961

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Renamed LESS variables with disgrete to discreet #4961

merged 1 commit into from
Mar 22, 2019

Conversation

nielslyngsoe
Copy link
Member

Renamed LESS variables with "disgrete" to "discreet"

@ghost ghost assigned nielslyngsoe Mar 12, 2019
@bjarnef
Copy link
Contributor

bjarnef commented Mar 12, 2019

@nielslyngsoe is there a difference on discrete and discreet?
Or is it similar to color vs colour?

@nielslyngsoe
Copy link
Member Author

@bjarnef so what I could Google "discrete" is for seperation of things where "discreet" is for subtle or careful.

@Shazwazza
Copy link
Contributor

I'm assuming that for these styles we are looking for discreet then?

@nielslyngsoe nielslyngsoe removed their assignment Mar 21, 2019
@bergmania bergmania self-assigned this Mar 22, 2019
@bergmania bergmania merged commit 0acc8e1 into dev-v8 Mar 22, 2019
@ghost ghost removed the state/review label Mar 22, 2019
@bergmania bergmania deleted the temp8-rename-color-variable-disgrete-to-discreet branch March 22, 2019 08:46
@nielslyngsoe nielslyngsoe mentioned this pull request Mar 26, 2019
Closed
@bergmania bergmania mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bergmania bergmania

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nielslyngsoe @bjarnef @Shazwazza @bergmania