Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Remember choice of layout in Users section #4779

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Feb 27, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes: #4756

Description

As described in #4756, the Users section doesn't remember your choice of layout; it reverts to "cards" upon every re-visit.

This PR changes that 😄 it looks like this:

remember-layout-for-users

Testing this PR

This PR has an impact on the existing "last used layout" handling in local storage. Thus it should be tested that all previously saved layouts (e.g. from content list view) still work when this PR is applied.

@emmaburstow
Copy link
Contributor

Kenn, again, great ux choice. This is a smart approach. Thanks,

Em

…ected-layout-in-users

# Conflicts:
#	src/Umbraco.Web.UI.Client/src/views/users/views/users/users.controller.js
@ghost ghost assigned nielslyngsoe Mar 19, 2019
@nielslyngsoe
Copy link
Member

@kjac great, thanks for ensuring the usage of listViewHelper

@nielslyngsoe nielslyngsoe merged commit d637a79 into umbraco:dev-v8 Mar 19, 2019
@kjac kjac deleted the v8-feature-save-selected-layout-in-users branch March 19, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants