Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Allow all content types at root if none are explicitly allowed #4418

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Feb 5, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes: #4414

Description

#4414 calls for allowing all content types at the root if none are explicitly marked as "Allow as root". This PR fixes that.

Testing this PR

This PR affects both content and media and the test steps below should be repeated for both content and media.

  1. Make sure that nothing is broken 😄 in other words test that if any content types are marked as "Allow as root" you can't create, move or copy any other content types to root.
  2. Disable "Allow as root" on all content types.
  3. Verify that you can create all content types at root.
  4. Verify that you can move and copy all content types to root - also from the recycle bin.

@warrenbuckley
Copy link
Contributor

All tested & reads fine. Thanks again @kjac 🎉

@warrenbuckley warrenbuckley merged commit 4a2b611 into umbraco:temp8 Feb 7, 2019
@kjac kjac deleted the v8-feature-allow-all-at-root branch February 7, 2019 13:48
kjac pushed a commit to kjac/Umbraco-CMS that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants