Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Add "Move" option for deleted items in the media tree #4056

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Jan 14, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

As promised here, this is the V8 implementation of the "Move" option for deleted items in the media tree.

To test this:

  1. Create a folder in the media tree and add some files in it.
  2. Delete the folder.
  3. Open one of the files in the deleted folder.
  4. Restore the file.
  5. Verify that you're given an option to move the file somewhere, as you can't restore to the original folder (it's still in the trash).
  6. Open the deleted folder in the recycle bin.
  7. Restore the folder.
  8. Verify that the folder can be restored to its original position in the tree.

It should look like this:

move-deleted-media

@emmaburstow
Copy link
Contributor

Morning @kjac!

Hope you had a good weekend. Thanks for you, we'll speak soon,

Emma

Copy link
Contributor

@emmaburstow emmaburstow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work, a usual. Works as advertised.

@nul800sebastiaan nul800sebastiaan merged commit 57b8a18 into umbraco:temp8 Jan 17, 2019
@nul800sebastiaan
Copy link
Member

Fantastic, thanks very much! 👍

@kjac kjac deleted the v8-move-deleted-media branch January 17, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants