Reload the recycle bin when deleting an item #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kjac 👍 |
|
Hi @kjac , i can confirm this works. Happy to approve 👍 Poornima |
poornimanayar
approved these changes
Dec 5, 2018
|
Lovely, thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The recycle bin doesn't reload when you delete item things in content or media. If you have the recycle bin open when deleting things, it's a bit worrying that they seem to simply just disappear entirely from the tree (you have to reload manually to see them):
With this PR, the recycle bin reloads if it's open (can't reload it if it's closed as that would force it to open):
🎄 3/24 🎄