Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to the .editorconfig file #3795

Merged
merged 4 commits into from
Dec 9, 2018

Conversation

ssougnez
Copy link

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes: #3752

Description

If Visual Studio is configured to add curly braces for one-liner block, the editorconfig file ensures that it won't happen for Umbraco.

@emmaburstow
Copy link
Contributor

Hi @ssougnez

Thanks for the Pr! As ever, one of us will take a look soon and let you know if we need you to do anything.

Thanks,

Emma

@emmaburstow emmaburstow self-assigned this Nov 29, 2018
Copy link
Member

@nul800sebastiaan nul800sebastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ssougnez - can sorry.. can you please change the whitespace in the .editoconfig file? 😎

Additionally, can you revert the added curly braces in the InstallHelper file as well (and then you can test if the .editorconfig file actually works when you format that file agian! 😉).

No idea why you'd have a vwd.webinfo, guess you opened the site as a file system web site? We encourage running it as a normal web project (just hit F5) but it's fine to put it in the git ignore.

.editorconfig Outdated Show resolved Hide resolved
sebastien-sougnez and others added 3 commits December 9, 2018 17:37
…l Studio does not add them even though it's configured that way

- Add vwd.webinfo to the gitignore to avoid pushing that file
@ghost ghost assigned nul800sebastiaan Dec 9, 2018
@nul800sebastiaan nul800sebastiaan merged commit 1d9bb46 into umbraco:dev-v7 Dec 9, 2018
@nul800sebastiaan
Copy link
Member

Thanks @ssougnez - fixed up some of the loose ends for you.

@ssougnez
Copy link
Author

ssougnez commented Dec 9, 2018

Cool, thanks.

Sorry for the additional work. I’m still not fully confortable with PR and so on :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants