Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find suitable version for font-awesome #3431

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Unable to find suitable version for font-awesome #3431

merged 2 commits into from
Oct 25, 2018

Conversation

janvanhelvoort
Copy link
Contributor

@janvanhelvoort janvanhelvoort commented Oct 25, 2018

Prerequisites

Description

bootstrap-social#~4.8.0 has a dependency on version 4.2 of font-awsome.

I want to update bootstrap-social to version 5, other depencies collide.

For now, rollback to font-awsome will solve the problem.

@nul800sebastiaan
Copy link
Member

@jannikanker Updating Bootstrap Social works for me though? Can you try again?

"bootstrap-social": "~5.1.1",

@janvanhelvoort
Copy link
Contributor Author

Hi @nul800sebastiaan,

I will take a look at an other solution, the one that @dawoe has suggested, than we don't need to update bootstrap-social.

Jan

@janvanhelvoort
Copy link
Contributor Author

Hi Sabastiaan,

The solution that dave suggested works, I have updated the pull request.

Copy link
Contributor

@dawoe dawoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works.

@nul800sebastiaan nul800sebastiaan merged commit 0daf197 into umbraco:dev-v7 Oct 25, 2018
@nul800sebastiaan
Copy link
Member

Yay, works for me too, good solution!

@nul800sebastiaan
Copy link
Member

Thanks very much @janvanhelvoort and @dawoe !

@nul800sebastiaan
Copy link
Member

Hi there @janvanhelvoort,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🙏

If you haven't heard already we have had a record breaking amount of PR's in both the CMS and the Documentation repository. You can read all about the numbers in the Umbraco Hacktoberfest Aftermath blog post.

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before November 21st 2018.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before December, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants