Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable move/copy button until a target node is selected #3250

Merged
merged 4 commits into from
Oct 23, 2018

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 11, 2018

Prerequisites

Description

#3241 describes the issue, although only for copying document types. The same issue is present quite a few other places as well. Here's the list of places I've found (and fixed with this PR):

  • Content move/copy
  • Media move
  • Document types move/copy
  • Media types move/copy
  • Data types move

To test:

  1. Perform each of the actions in the list above
  2. Verify that the "move" or "copy" button is disabled in the action dialog until a target node is selected

@abjerner
Copy link
Contributor

@kjac thanks for another PR 👍

I just skimmed through your changes, and couldn't spot anything wrong. Nevertheless, I'll give your changes a test, and report back ;)

@abjerner abjerner assigned abjerner and unassigned abjerner Oct 11, 2018
@abjerner abjerner self-requested a review October 11, 2018 07:41
@abjerner
Copy link
Contributor

Works as described - thanks for another great PR 👍

Copy link
Member

@nul800sebastiaan nul800sebastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, works great @kjac ! If you can approved changing ng-if to ng-show then this can be merged. 👍

src/Umbraco.Web.UI.Client/src/views/media/move.html Outdated Show resolved Hide resolved
@kjac
Copy link
Contributor Author

kjac commented Oct 23, 2018

@nul800sebastiaan while we're at it I'll replace the other similar ng-if's ... I'll just be a minute :)

@kjac
Copy link
Contributor Author

kjac commented Oct 23, 2018

There. All done!

@nul800sebastiaan
Copy link
Member

😍 SuperTak @kjac ! 😁

@nul800sebastiaan nul800sebastiaan merged commit f699768 into umbraco:dev-v7 Oct 23, 2018
@kjac kjac deleted the fix-disable-move-copy-buttons branch October 24, 2018 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants