Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nested Content "second time dragging" issue #3083

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 1, 2018

Prerequisites

Description

This PR ensures that the items in the Nested Content item list aren't thrown out of place when dragging them around.

nc drag offset after

To test it:

  1. Drag an item twice in a Nested Content item list without reloading the page in between
  2. Verify that the dragged item stays within the list while dragging - both times.

@emmaburstow
Copy link
Contributor

Hi again @kjac ;-)

We'll have a good look at this work and let you know if we need anything. Thanks for the handy gif!

Emma, Community Pull Request team

@nul800sebastiaan
Copy link
Member

Hey @kjac - while this may have fixed the second time dragging, I now seem to have a problem on the FIRST time dragging. This only happens after the page loads and you start dragging for the first time, everything seems fine after the first time. Once I click the icon to sort, the item I'm dragging just disappears. Is this something you can reproduce too? Maybe it's just me.

3083

@kjac
Copy link
Contributor Author

kjac commented Oct 3, 2018

@nul800sebastiaan that's a scrolling issue. If you've scrolled your page down a bit, the initial offset of the dragged item is wrong. It fixes itself though as soon as you move the dragged item around in the list.

The issue is already present in the current version and isn't fixed by this PR 😄

@nul800sebastiaan
Copy link
Member

@kjac Wonderful, I look forward to seeing another PR for that then! ;-)

Cool, I'll merge this because (indeed) it fixes what it is supposed to! 👍

@kjac
Copy link
Contributor Author

kjac commented Oct 3, 2018

Nice!

@kjac kjac deleted the fix-nc-dragging-offset branch October 3, 2018 13:26
@ghost ghost assigned emmaburstow Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants