Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the correct color for items in the Nested Content item picker #3082

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 1, 2018

Prerequisites

Description

This PR ensures that the icon colors in the Nested Content item picker are consistent with the icon colors in the Nested Content item list.

nc icon color after

To test it:

  1. Create a doctype with a Nested Content property
  2. The Nested Content property must have at least one doctype with a black icon
  3. Open the item picker in the Nested Content property and verify that the doctype icon is indeed black

@emmaburstow
Copy link
Contributor

Hi @kjac

Thanks for the pr and the description of behaviours. Looks fab! I'll have a look at it in detail and one of us will let you know if we need anything - on this and the other prs.

Emma, Community Pull Request team

@nul800sebastiaan nul800sebastiaan merged commit 7c28e89 into umbraco:dev-v7 Oct 3, 2018
@nul800sebastiaan
Copy link
Member

Thanks @kjac - works as advertised! 👍

@nul800sebastiaan
Copy link
Member

Hi there @kjac,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🙏

If you haven't heard already we have had a record breaking amount of PR's in both the CMS and the Documentation repository. You can read all about the numbers in the Umbraco Hacktoberfest Aftermath blog post.

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before November 21st 2018.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before December, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators

@kjac
Copy link
Contributor Author

kjac commented Nov 6, 2018

You are so very very welcome! Don't think you're rid of me just because October has come to an end 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants