Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Created Date" field when the content hasn't yet been created #2901

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

abjerner
Copy link
Contributor

@abjerner abjerner commented Sep 3, 2018

I think it is a bit weird that a creation date is shown even before a content item has been created. Especially when the date is in year 1 👴

image

With this PR, the property is hidden when the numeric ID is zero. It will now look like this instead:

image

Once the content item has been published, the "Created Date" property will be shown as intended.

@ghost ghost assigned abjerner Sep 3, 2018
@ghost ghost added the state/review label Sep 3, 2018
@abjerner abjerner removed their assignment Sep 3, 2018
@abjerner
Copy link
Contributor Author

abjerner commented Sep 4, 2018

I first noticed this after I had created my PR, but wouldn't it make sense to hide the "Id" property as well? The numeric ID isn't 0, but rather undefined as the content item hasn't been created yet. Also, the GUID isn't the one actually used, as the content item gets a different GUID. Any thoughts?

@nul800sebastiaan
Copy link
Member

Yep, that would make total sense @abjerner - go for it! 👍

@ghost ghost assigned abjerner Sep 4, 2018
@abjerner
Copy link
Contributor Author

abjerner commented Sep 4, 2018

Done 😄

@nul800sebastiaan
Copy link
Member

Wonderful, thanks very much @abjerner ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants