Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tree access to webhooks #15156

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Add tree access to webhooks #15156

merged 3 commits into from
Nov 7, 2023

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Nov 7, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

While working on #15147 I noticed webhooks tree just require permissions to logs.

But couldn't there be use-cases, where some users should have access to log viewer, but not allowed to access and manage webhooks?

Copy link

github-actions bot commented Nov 7, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef
Copy link
Contributor Author

bjarnef commented Nov 7, 2023

@Zeegaan @bergmania I think we need this change as well?

@Zeegaan
Copy link
Member

Zeegaan commented Nov 7, 2023

Yep, we didn't do this intentionally for rc1 (time crunch 😅) But had a task to implement this for rc2!
Thanks for this 🙏

@Zeegaan Zeegaan merged commit a648dda into umbraco:v13/dev Nov 7, 2023
@bjarnef bjarnef deleted the patch-5 branch November 7, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants