Open blueprint editor from tracked references

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #12753

Description

Currently when a content template (blueprint) has a reference to a media item, the URL (right-click action) and action on anchor click doesn't work.

This PR introduce an infinite editor for blueprints as well, so it works similar to content, media and member.

chrome_CE4PGs6dtg.mp4

An additional concern is that it is possible to remove the default content templates tree from settings, create a custom tree node inheriting from ContentBlueprintTreeController adding this to e.g. content section. Not sure if we can get the alternative section and tree for content templates in core the default tree node has been removed - or maybe we need a setting to override this. There is also a discussion here about if content templates by default should be moved to content section: #11743

I also wonder what should happens when logged in as content editor with no access to settings section?

Currently the content editor see the content template in the references, with these changes the user can also open the content template in the infinite mode and seems to be able to save as well.

chrome_nOUy1WXX37.mp4

Is this how we want it to work, should the content template reference be locked in this scenario or should we just exclude/filter the reference from the table?
In a specific project we removed the default content templates tree and inserted a custom tree inheriting the default ContentBlueprintTreeController and inserted this into content section. In this case we do want content editors to see the references.

A second thing is that the content editor can right-click to open/edit, but in case he/she hasn't access to settings section, it seems to redirect to content section instead.

[github-actions]

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[bjarnef]

@iOvergaard @nielslyngsoe @nul800sebastiaan I think this it better than what we currently have, but I am not sure how we should handle move of tree to another section? By default it is located in Settings, but we have a project where we removed the default ContentTemplates tree node and registered our own (inheriting the default ContentTemplates tree controller) to insert this into Content section due a demand from the client. By default content editors can create content templates, but not edit or delete these. Maybe another config setting or a server variable exposing section of first ContentTemplates tree controller (either default or one inheriting the default controller).

See #11796 as reference.

[bjarnef]

@leekelleher maybe you have some feedback on this since you worked a bit with Content Templates / Blueprints in Contentment package.

[bjarnef]

@nikolajlauridsen do you know a way to find first registred ContentBlueprintTreeController so we can ensure the link works when moved to another section? Or do we need another config option? 😄

[emmagarland]

Hi again @bjarnef 🙂 !

Just going through some of the longer running PRs, and noticed this one (it's been a while, so there are now some conflicts sorry!)

Did you need anything else to progress this one? It seems you had some questions?

Thanks,

Emma

[bjarnef]

Hi @emmagarland

Yeah, we need to revolve the merge conflicts 🙂

As mentioned here #12764 (comment) it is possible to move (or removed and register own ContentBlueprintTreeController), so regarding this PR which section should we route to, it can be Settings section by default.

Either we need a dynamic way to find (first) registrered ContentBlueprintTreeController or another config option to change this to e.g. Content section.

When moved/registered in Content section it also moved blueprints and existing content tree under two root folders in content section. I haven't tested, but I think it may be possible to move the content templates tree under a tree group, so content nodes isn't nested under another level.

[emmagarland]

Thanks @bjarnef, I'll add it to my assigned PRs to make sure I can progress this with you 😃

I'll then look into the replication steps and continue from there after I cover off the other PRs I'm working on.

Many thanks again for your contributions!

Emma

[emmagarland]

Hi @bjarnef

Just to let you know, this one hasn't been forgotten - it is being discussed internally with HQ due to the user permissions questions it raises.

Congratulations on having created your 500th PR, too! Amazing work 🥇

Best wishes

Emma

[bjarnef]

Hi @emmagarland

Any update on this one?

1. If the user doesn't have access to the settings section (or the section the content templates tree belongs to), maybe the link should just not open the content node - or show node name as text.
2. It is possible to remove the content templates tree and register your own inheriting the core tree controller and register it in e.g. content section. Any way to know about this dynamically or should we just have a settings in appsettings.json to handle this? In that case this could be used to insert the Content Templates tree in the configured section.

It may also need to be considered regarding Reusable Content if it add a Library section, where the Content Templates could be moved to, but could still be useful to allow moving the tree to another section like Content section or a custom section.

[emmagarland]

Hi @bjarnef,

Not yet but thanks for the additional information, I will ask HQ to see if there is an update and you will get a reply soon,

Thanks

Emma

[nul800sebastiaan]

Hi @bjarnef, as we talked about a few weeks ago, I'll close this one while we focus on getting Bellissima in good shape.

I'll add the generic comment for people who are reading along with this:

As you may or may not know, we're working on a rewrite of the Umbraco backoffice, codenamed Bellissima (https://umbraco.com/blog/bellissima-preview-releases-of-the-new-backoffice/) and we're trying to make sure that it has feature parity with the current AngularJS-based backoffice.

We're at a point in the development phase where we want to start wrapping up a beta version to ship some time "soon" and we're going to have to implement a feature freeze on the current backoffice so that we don't keep increasing the scope of Bellissima. Unfortunately that means we're going to have to stop accepting PRs like this one that create significant changes to the current backoffice.

As a general rule from now on, we're still happy for features in C# code but anything that gets introduced or refactored in AngularJS probably won't make it. Bugfixes are still great of course!

Thanks for the efforts here and we hope to see you back as a contributor soon! 👍