-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ImageSharp to latest version #12651
Bump ImageSharp to latest version #12651
Conversation
Hi there @jrunestone, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Thanks @jrunestone! We'll ship this with v10.1.0 👍 |
What's going on here, are you getting a 404 on the image itself? Or is the image displaying but in the wrong size? The issue was that an image with åäöø etc in the filename that had a crop or resize wouldn't show in the correct size, but it would still show up. |
I'm getting a 404 on the image, both on frontend and backoffice |
It's the same for pdf files.. |
Prerequisites
Fixes issues with image names containing special characters (diacritics, umlauts, ...) in conjunction with ImageSharp operations such as resizing and cropping. Should fix #12598 and perhaps fix #12559.
Description
After upgrading to ImageSharp 2.0.0 image filenames containing non-ascii characters (myöimage.jpg, somé-othèr.jpg) fail to resolve on the file system causing image crops to fail silently in Umbraco. This PR over at ImageSharp should fix that.
Test by uploading an image with a filename containing characters such as è or á or å, ä, ö (eg somé-imagè.jpg) and then try to display a crop of it, or browse to the image directly adding ?width=100 to the url.