Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ImageSharp to latest version #12651

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Bump ImageSharp to latest version #12651

merged 2 commits into from
Jul 12, 2022

Conversation

jrunestone
Copy link
Contributor

@jrunestone jrunestone commented Jul 3, 2022

Prerequisites

  • I have added steps to test this contribution in the description below

Fixes issues with image names containing special characters (diacritics, umlauts, ...) in conjunction with ImageSharp operations such as resizing and cropping. Should fix #12598 and perhaps fix #12559.

Description

After upgrading to ImageSharp 2.0.0 image filenames containing non-ascii characters (myöimage.jpg, somé-othèr.jpg) fail to resolve on the file system causing image crops to fail silently in Umbraco. This PR over at ImageSharp should fix that.

Test by uploading an image with a filename containing characters such as è or á or å, ä, ö (eg somé-imagè.jpg) and then try to display a crop of it, or browse to the image directly adding ?width=100 to the url.

@github-actions
Copy link

github-actions bot commented Jul 3, 2022

Hi there @jrunestone, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan nul800sebastiaan merged commit 3778f0d into umbraco:v10/contrib Jul 12, 2022
@nul800sebastiaan
Copy link
Member

Thanks @jrunestone! We'll ship this with v10.1.0 👍

@nul800sebastiaan nul800sebastiaan added release/10.1.0 type/feature status/dependency-update This change requires a dependency to be updated (Deploy, Forms, Courier) dependencies Pull requests that update a dependency file community/pr labels Jul 12, 2022
@thomashdk
Copy link
Contributor

thomashdk commented Aug 8, 2022

Just updated to 10.1.0 to get this fixed.

Still an issue.
image

image

@jrunestone
Copy link
Contributor Author

What's going on here, are you getting a 404 on the image itself? Or is the image displaying but in the wrong size? The issue was that an image with åäöø etc in the filename that had a crop or resize wouldn't show in the correct size, but it would still show up.

@thomashdk
Copy link
Contributor

I'm getting a 404 on the image, both on frontend and backoffice

@thomashdk
Copy link
Contributor

It's the same for pdf files..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr dependencies Pull requests that update a dependency file release/10.1.0 status/dependency-update This change requires a dependency to be updated (Deploy, Forms, Courier) type/feature
Projects
None yet
3 participants