Fix bulk property variant data updates #12569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmania
pushed a commit
that referenced
this pull request
Jan 30, 2024
(cherry picked from commit a242a42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #10383.
Description
Updating the
Vary by culturesetting of a property still resulted in an exception being thrown, as mentioned in #11369 (comment). This PR adds grouping on 2 bulk updates to ensure they also don't exceed the maximum amount of SQL parameters.I've targeted v8, as that's what the above issue/PR used and we should be able to merge this up to the latest versions (the file moved from the
Umbraco.CoretoUmbraco.Infrastructureproject though).To test, you need a lot of content/variants (more than 2000) and then change the
Vary by cultureas described in the linked issue.