Fix media tracking of items added via macro parameters in RTE and Grid

[elit0451]

Details

Fixes #8131 for Umbraco 9

After adding the item tracking improvements, there was still the issue that media items were not tracked when added via macro parameters in Rich Text Editor and Grid layout. @marcemarc had made a PR for Umbraco 8 resolving the issue (🎉 H5YR! 💪 ) and this is the fix for Umbraco 9.

Test

• Have the SK installed

  • Create a Partial View Macro File called InsertFiles.cshtml ( ❗ Note: code below)

  • Allow the macro with the same name to be used in Rich Text Editor and the Grid

  • Add a macro parameter (ex: Files (files) : Umbraco.MultipleMediaPicker)

  • In a Rich Text area on a content node, insert the macro and pick a media item as the macro param

    • It should result in the following:
      

  • Save and Publish

  • View the media item in the backoffice, and you should see that this is now referenced from this page

    • If you pick a folder from the Media section, all its contents will be listed in the macro, but the reference is made to the folder itself and therefore can be found on the folder's info app

  • You can do the same thing with the Grid

    • Either pick a Macro directly
    • Or add a RTE in a Grid and reference the macro from there

---

Contents of InsertFiles.cshtml:

@inherits Umbraco.Cms.Web.Common.Macros.PartialViewMacroPage
@using Umbraco.Cms.Core.Models.PublishedContent
@using Umbraco.Cms.Core
@using Umbraco.Cms.Core.Routing
@using Umbraco.Extensions

@inject IPublishedContentQuery PublishedContentQuery
@inject IVariationContextAccessor VariationContextAccessor
@inject IPublishedUrlProvider PublishedUrlProvider


@{ var mediaIds = Model?.MacroParameters["files"] as string; }

@if (mediaIds != null)
{
    <div class="row">
        @foreach (var mediaId in mediaIds.Split(','))
        {
            var media = PublishedContentQuery.Media(mediaId);

            @* a single image *@
            if (!media.IsDocumentType("Folder"))
            {
                <div class="col-xs-6 col-md-3">
                    <a href="@media.Url(PublishedUrlProvider)" class="thumbnail">@media.Name</a> [@System.IO.Path.GetExtension(@media.Url(PublishedUrlProvider).ToString()).Substring(1)]
                </div>
            }

            @* a folder with images under it *@
            foreach (var image in media.Children(VariationContextAccessor))
            {
                <div class="col-xs-6 col-md-3">
                    <a href="@image.Url(PublishedUrlProvider)" class="thumbnail">@image.Name</a> [@System.IO.Path.GetExtension(@image.Url(PublishedUrlProvider).ToString()).Substring(1)]
                </div>
            }
        }
    </div>
} 

[Zeegaan]

Pattern matching is the new hotness 🔥

[Zeegaan]

Great job! I've fixed up some of the small edge-cases but the rest LGTM! 👓

[bjarnef]

@Zeegaan shouldn't it just use Length here since the aliases is string[].

for example:

if (aliases?.Length == 0)
{
    return base.GetMany();
}

As far I know Any() check first item if collection, but with Array, List, ICollection etc, Length or Count property already know the size of the array/collection.

[Zeegaan]

Hey @bjarnef, thanks for your comment, i had to check how this works 👀 When it is an array, Any() will also use the Count property like this:

And because of that, i think its more readable if we use Any() instead of Length

[Zeegaan]

Cherry picked for 9.4

[marcemarc]

Thanks @elit0451 @Zeegaan !!!