V9: Fix backoffice javascript loading slowly #11714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2021 15:23
By default Smidge will always try and use Brotli (br), this compression is good in the the sense that it compresses the file quite a bit, but sadly it's super super slow, like 10 seconds for backoffice js slow.
bergmania
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Looks good..
Ill just add the link to the smidge issue, so we remember what to clean up if there is a fix in there:
Shazwazza/Smidge#135
bergmania
pushed a commit
that referenced
this pull request
Dec 1, 2021
* Update Smidge * Add SmidgeRequestHelper to override the compression order By default Smidge will always try and use Brotli (br), this compression is good in the the sense that it compresses the file quite a bit, but sadly it's super super slow, like 10 seconds for backoffice js slow. * Remove unnecessary new keyword Co-authored-by: nikolajlauridsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This fixes #10252 and #11393
The problem was that,
umbraco-backoffice-js.jsandumbraco-backoffice-extensions-js.jsloaded extremely slowly (~10 seconds for each), when the debug was set to false in the appsettings.Turns out this was actually two separate issues, but this PR fixes both, the
umbraco-backoffice-extensions-js.jsproblem was actually a bug in Smidge, see this for more information.The
umbraco-backoffice-js.jswas simply because the Brotli compression for some reason is extremely slow, and smidge will always prefer this. This fix this issue I've replaced theRequestHelperthat comes with Smidge with our ownSmidgeRequestHelperwhich then wraps the smidgeRequestHelper, but changes the default, so Smidge will now default to gzip, and only use Brotli if there is no other option.Testing
appsettings.Development.jsonfileappsettings.Development.jsonUmbraco.TheStarterKit