Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Umbraco static assets included when publish --no-build #11665

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Ensure Umbraco static assets included when publish --no-build #11665

merged 2 commits into from
Nov 22, 2021

Conversation

p-m-j
Copy link
Contributor

@p-m-j p-m-j commented Nov 19, 2021 •
edited by nul800sebastiaan
Loading

Closes #11662

@p-m-j p-m-j force-pushed the v9/bugfix/include-static-assets-publish-no-build branch from 3d21656 to 6bf628a Compare November 19, 2021 12:12
@p-m-j p-m-j changed the base branch from v9/dev to v9/9.1 November 19, 2021 12:12
@p-m-j p-m-j force-pushed the v9/bugfix/include-static-assets-publish-no-build branch from 5823055 to 29f8ae1 Compare November 19, 2021 12:29
@p-m-j p-m-j force-pushed the v9/bugfix/include-static-assets-publish-no-build branch from 29f8ae1 to e4eaac2 Compare November 19, 2021 12:34
@p-m-j
Copy link
Contributor Author

p-m-j commented Nov 19, 2021 •
edited
Loading

Force pushes

  1. Wrong base (dev vs 9.1)
  2. DRY
  3. PreserveNewest vs Always

@ronaldbarendse
Copy link
Contributor

@p-m-j I've replicated the problem in 9.1.0, built the NuGet packages locally using this PR (resulting in 9.1.1) and used that to create a new project with the above commands: works exactly as expected now! 🎉

@bergmania
Copy link
Member

I also tested on Umbraco cloud

With a 9.0.1 *.csproj (simulating an upgrade) and with a 9.1.1 *.csproj (simulating a new project)
image

@bergmania bergmania merged commit b58a0cf into v9/9.1 Nov 22, 2021
@bergmania bergmania deleted the v9/bugfix/include-static-assets-publish-no-build branch November 22, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmania bergmania bergmania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-m-j @ronaldbarendse @bergmania