Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending invite emails #11609

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

elit0451
Copy link
Contributor

Fixes: #11453

The issue occurs only on Umbraco Cloud due to a special "send email flow" which broke because of the change introduced in #11266. More specifically, there, the SMTP settings are not in the config files and sending null will make the emailMessage.From to always be null while the configuredEmailAddress won't also be setup:

var fromEmail = string.IsNullOrEmpty(emailMessage.From) ? configuredFromAddress : emailMessage.From;


This PR makes sure to fall back to the current user's email if the SMTP settings are not configured.

@bergmania bergmania changed the base branch from v9/dev to v9/9.1 November 15, 2021 07:07
@bergmania
Copy link
Member

Changes looks fine and should be equivalent for non-cloud users :)

@bergmania bergmania marked this pull request as ready for review November 15, 2021 12:13
@bergmania bergmania merged commit 169fc7c into v9/9.1 Nov 15, 2021
@bergmania bergmania deleted the v9/bugfix/AB14726-fix-user-invite branch November 15, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants