Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatypesettings infinite overlay view: Add fallback texts and map label to input id #11516

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Datatypesettings infinite overlay view: Add fallback texts and map label to input id #11516

merged 2 commits into from
Oct 27, 2021

Conversation

BatJan
Copy link
Contributor

@BatJan BatJan commented Oct 26, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

Description

In this PR I have added a new translation key, which was missing for part of the text and I have mapped missing fallback texts ensuring a text will be displayed in case other language files are out of sync.

Furthermore I have ensured that the name label, refers the associated input as well improving accessibility a wee bit.

@umbrabot
Copy link

umbrabot commented Oct 26, 2021

Hi there @BatJan, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants