v9: Fixing flaky cypress test "Macro in Grid" #11485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 25, 2021 13:39
p-m-j
reviewed
Oct 25, 2021
| @@ -759,8 +759,11 @@ context('Content', () => { | |||
| // Click macro | |||
| cy.get(':nth-child(4) > .umb-card-grid-item > :nth-child(1)').click(); | |||
| // Select the macro | |||
| cy.get('.umb-card-grid-item').contains(macroName).should('be.visible'); | |||
| cy.wait(500); | |||
There was a problem hiding this comment.
Do you have suggestions how to avoid the wait? We tried a couple of things, and i looks like cypress can click the item before a click handler is attached.
p-m-j
reviewed
Oct 26, 2021
tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
Outdated
Show resolved
Hide resolved
Zeegaan
commented
Oct 26, 2021
tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
Outdated
Show resolved
Hide resolved
Zeegaan
commented
Oct 26, 2021
tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
Outdated
Show resolved
Hide resolved
|
For future readers, the issue was the click hit the component umb-icon which was getting rebound to render an svg (and so detatched, click rejected by cypress) , moving the click target to bottom (or anywhere other than dead center) bypasses the issue. |
nul800sebastiaan
pushed a commit
that referenced
this pull request
Nov 3, 2021
* fixed flaky macro test and updated cypress version * fixed flaky macro test and updated cypress version * Update package.json * Fixed failing tabs test * Amend magic numbers with actual wait * Update tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts * Updated UI to click on button instead of icon * Make macro test click bottom to ensure we're not clicking on icon Co-authored-by: Nikolaj Geisle <[email protected]> (cherry picked from commit 34be464) # Conflicts: # tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Tabs/tabs.ts
nul800sebastiaan
pushed a commit
that referenced
this pull request
Nov 3, 2021
* fixed flaky macro test and updated cypress version * fixed flaky macro test and updated cypress version * Update package.json * Fixed failing tabs test * Amend magic numbers with actual wait * Update tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts * Updated UI to click on button instead of icon * Make macro test click bottom to ensure we're not clicking on icon Co-authored-by: Nikolaj Geisle <[email protected]> (cherry picked from commit 34be464) # Conflicts: # tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Tabs/tabs.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
How to test
npm install&npm run test