-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New design for the default 404 page #11468
Conversation
Hi there @skttl, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
var backOfficePath = globalSettings.Value.GetBackOfficePath(hostingEnvironment); | ||
} | ||
<!doctype html> | ||
<html class="no-js" lang="en"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The no-js
should probably not be applied unless you have some javascript to remove the script.
Alternatively add something like this:
<script>
document.documentElement.classList.remove("no-js");
</script>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be removed from https://github.com/umbraco/Umbraco-CMS/blob/v9/contrib/src/Umbraco.Web.UI/umbraco/UmbracoWebsite/NoNodes.cshtml too :)
Hi @skttl , Thanks for this PR 👍 , it makes the 404 look better yet still calling to be customized 😉 |
Prerequisites
If there's an existing issue for this PR then this fixes #9562
Description
This one adds a new view for the 404 page
When not in debug mode, it will only write "Page Not Found", like so:
Testing
Navigate to a non existing url, and verify that you no longer get the old, ugly 404 page.