Bugfix/11442/migration steps are skipped v8.17 to v9

[jaddie]

This fixes #11442
When a site is setup and migrated to V8.17, or as a fresh install on V8.17 and is migrated to V9, the site will break due to missing columns in the members table.

This migration is not run because due to the way the plan is written the migrations are for a prior version, it would seem that migrating from 8.15 or below this would not be a problem, and is a complication because of the V9 RC1

This moves the migrations out so they are always run & fixes the problem.

Side note: the guid for the V9 version appears to be missing the {} around the GUID, however I think changing this at this point would likely be too risky and have the potential to cause broken installs due to having an unknown state.

This has been tested by myself & @rickbutterfield

[umbrabot]

Hi there @jaddie, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[FrankLN]

@jaddie do you know if this also fixes the additional bug related to the migration added this morning in the original i forum post? It looks like some tables are missing.
https://our.umbraco.com/forum/umbraco-9/107379-upgrade-from-817-to-901-causing-error#comment-334156

[rickbutterfield]

@jaddie do you know if this also fixes the additional bug related to the migration added this morning in the original i forum post? It looks like some tables are missing. https://our.umbraco.com/forum/umbraco-9/107379-upgrade-from-817-to-901-causing-error#comment-334156

@FrankLN yes, I can confirm that on my migrated 8.17 database both the umbracoExternalLoginToken and umbracoLogViewerQuery tables exist, and the foreign key constraints are modified too.

[bergmania]

Hi.. Nice work, but I'm afraid I found an issue,

As far as I can see, this will never execute the 8.17 migrations {153865E9-7332-4C2A-9F9D-F20AEE078EC7} if you update from 9.0rc1-3 (having state {5060F3D2-88BE-4D30-8755-CF51F28EAD12}) - This will be a problem.

If you update from 9.0rc4, it will already have been executed - So this case is fine.

I think, the most safe solution is the execute the AddPropertyTypeGroupColumns migration again using a new Id. Even that is will do a bit of duplicate work, is should be idempotent.

[jaddie]

Hey, cheers :)

I'm glad you've found something, as its concerning that something as important as the migrations has slipped like this, I've just quickly made a change to it, is this what you were thinking would resolve it? I'll be honest I've not had time to test the code, just wanted to see if it was what you were thinking or not.

Cheers
Jaddie

[bergmania]

Hey @jaddie.. Not completely..

The issue is users of RC1 - RC3 already has state {5060F3D2-88BE-4D30-8755-CF51F28EAD12}, so with the current code it will only execute "5E02F241-5253-403D-B5D3-7DB00157E20F".

I think the new migration has to be inserted after the RC1 state {5060F3D2-88BE-4D30-8755-CF51F28EAD12}.

Users on Rc4 or later already has executed that migratation https://github.com/umbraco/Umbraco-CMS/blob/release-9.0.0-rc004/src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs

[bergmania]

Thanks alot 💪

[umbrabot]

Hi there @jaddie,

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 31st, 2021.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

We have blogged about this year's hacktoberfest in a recap post, have a read about at all the achievements for this year!

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco Teams

[nul800sebastiaan]

Hi @jaddie, you might have missed the call for Hacktoberfest rewards since I have no registration for you. Please fill in the Hacktoberfest form before the end of the week if you want swag, else we'll plant trees 👍 https://docs.google.com/forms/d/e/1FAIpQLScaxJCay8M-uvyvNmX7o4xVibuMh_yfokjk3csyqFuGwb7DgA/viewform

[jaddie]

Thanks for that @nul800sebastiaan for some reason neither of these comments had notified me!