Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8/feature/app header localized titles #11429

Merged
merged 6 commits into from
Oct 22, 2021
Merged

V8/feature/app header localized titles #11429

merged 6 commits into from
Oct 22, 2021

Conversation

prjseal
Copy link
Contributor

@prjseal prjseal commented Oct 20, 2021

Added localized title attributes to the help and search buttons in the app header (top right of umbraco backoffice).

image

As it is a backoffice UI improvement, I have submitted it to v8 so it can be cherry picked for v9 too

@prjseal
Copy link
Contributor Author

prjseal commented Oct 20, 2021

You can ignore the other commits, there is only 1 file actually changed in this. The rest was my repo catching up with merged changes

@umbrabot
Copy link

umbrabot commented Oct 20, 2021

Hi there @prjseal, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Oct 22, 2021

Thanks @prjseal for spotting this, accessibility improvements are always nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants