-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8/feature/app header localized titles #11429
V8/feature/app header localized titles #11429
Conversation
I think it will be useful to include a link to the documentation on how to create a custom 404
…er (top right of Umbraco)
You can ignore the other commits, there is only 1 file actually changed in this. The rest was my repo catching up with merged changes |
Hi there @prjseal, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Thanks @prjseal for spotting this, accessibility improvements are always nice 👍 |
Added localized title attributes to the help and search buttons in the app header (top right of umbraco backoffice).
As it is a backoffice UI improvement, I have submitted it to v8 so it can be cherry picked for v9 too