-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor edits to the XPath query help sheet #11385
Minor edits to the XPath query help sheet #11385
Conversation
Since the placeholder is only replaced if it's at the beginning of the query, I've added a note about it. Also made the spelling of XPath consistent and fixed a nesting error in the HTML.
Hi there @greystate, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @greystate - Good to get some consistancy and a bit of a tidy up. The note is also useful for those not used to XPath.
* Clarify the use of placeholders Since the placeholder is only replaced if it's at the beginning of the query, I've added a note about it. Also made the spelling of XPath consistent and fixed a nesting error in the HTML. * Rephrase a couple of sentences (cherry picked from commit e04efe6)
Cherry picked for v8.18 in 2fa31db |
* Clarify the use of placeholders Since the placeholder is only replaced if it's at the beginning of the query, I've added a note about it. Also made the spelling of XPath consistent and fixed a nesting error in the HTML. * Rephrase a couple of sentences (cherry picked from commit e04efe6)
Prerequisites
Description
This fixes a couple of inconsistencies, spelling-wise on the Multinode Treepicker's XPath query help sheet.
Also adds a note clarifying that the placeholder only works when used at the beginning of the query.
Testing the changes
Here's a couple of before and after screenshots to show the results of this PR - to test if it has been applied, create a new Datatype using the Multinode Treepicker and click the
Query for root node with XPath
link. Then click theShow XPath query help
link and compare the screen with the "after" screenshot (or maybe just make sure that XPath is spelled consistently).Before:
After: