Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published Content Query has "skip" applied twice #11378

Conversation

matthewcare
Copy link
Contributor

Skipping is done as part of the query now, causing skip to be applied twice

Prerequisites

  • I have added steps to test this contribution in the description below

Related to #11377

Whilst investigating the problem with skip and take returning inconsistent results, I found that more items were skipped than intended.

QueryOptions.SkipTake(skip, take) handles the skipping now, so the later skip is not required

Skipping is done as part of the query now, causing `skip` to be applied twice
Fix more areas where skip is applied twice
@umbrabot
Copy link

Hi there @matthewcare, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Member

@bergmania bergmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@elit0451
Copy link
Member

elit0451 commented Nov 3, 2021

Thanks @matthewcare for getting to the bottom of this! Merging 🎊

@elit0451 elit0451 merged commit 1c4cab5 into umbraco:v9/contrib Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants