-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more detailed message when deleting items in the list view #11375
Added more detailed message when deleting items in the list view #11375
Conversation
Hi there @prjseal, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Thanks @prjseal for this PR, it works perfectly and it makes the multi-delete indeed more clear 👍 I took the liberty of adding the French translation as well, I hope you won't mind 😁 Cheers! |
) * Added more detailed message when deleting items in the list view * Update FR language file (cherry picked from commit 14fe7d9) # Conflicts: # src/Umbraco.Web.UI/Umbraco/config/lang/en.xml # src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
Cherry-picked for v8.18 in 1dbef85 |
) * Added more detailed message when deleting items in the list view * Update FR language file (cherry picked from commit 14fe7d9) # Conflicts: # src/Umbraco.Web.UI/Umbraco/config/lang/en.xml # src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
This is a new feature.
When deleting items in a list view, it would be great to know how many you are deleting when the confirm dialog shows.
This PR takes you from this:
To This:
This PR was created during the live hacktoberfest Jam session on the Umbraco discord server with help from Umbraco HQ and other community members. @warrenbuckley @emmaburstow @nul800sebastiaan