Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more detailed message when deleting items in the list view #11375

Merged
merged 3 commits into from
Oct 16, 2021
Merged

Added more detailed message when deleting items in the list view #11375

merged 3 commits into from
Oct 16, 2021

Conversation

prjseal
Copy link
Contributor

@prjseal prjseal commented Oct 14, 2021

This is a new feature.

When deleting items in a list view, it would be great to know how many you are deleting when the confirm dialog shows.

This PR takes you from this:

image

To This:

image

This PR was created during the live hacktoberfest Jam session on the Umbraco discord server with help from Umbraco HQ and other community members. @warrenbuckley @emmaburstow @nul800sebastiaan

@umbrabot
Copy link

umbrabot commented Oct 14, 2021

Hi there @prjseal, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Oct 16, 2021

Thanks @prjseal for this PR, it works perfectly and it makes the multi-delete indeed more clear 👍

I took the liberty of adding the French translation as well, I hope you won't mind 😁

Cheers!

@mikecp mikecp merged commit 14fe7d9 into umbraco:v9/contrib Oct 16, 2021
nul800sebastiaan pushed a commit that referenced this pull request Nov 3, 2021
)

* Added more detailed message when deleting items in the list view

* Update FR language file

(cherry picked from commit 14fe7d9)

# Conflicts:
#	src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
#	src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
@nul800sebastiaan
Copy link
Member

Cherry-picked for v8.18 in 1dbef85

nul800sebastiaan pushed a commit that referenced this pull request Nov 3, 2021
)

* Added more detailed message when deleting items in the list view

* Update FR language file

(cherry picked from commit 14fe7d9)

# Conflicts:
#	src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
#	src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants