[v8] Resolve incorrect ContentSavedState for failed publish #11356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #11290 (for v8)
|
I just wanna say a big thank you to @p-m-j for helping me with this issue! We bumped our heads against the wall for 2 days with this issue, but finally found a good solution without breaking changes 💪 I tested this and it works great and the code looks good to me 👓 Will be happy to merge as soon as all the tests have passed! |
Zeegaan
deleted the
v8/bugfix/fix-incorrect-edited-state-for-failed-publish-11290
branch
|
I just wanna say a big thank you to @Zeegaan for helping me with this issue :p |
p-m-j
pushed a commit
that referenced
this pull request
Oct 18, 2021
bergmania
pushed a commit
that referenced
this pull request
Oct 19, 2021
* Nuke Content.ContentSchedule Can't make an omelette without breaking eggs * Fix read view models * Fix Save, Save & Schedule, Save & Publish * Fix scheduled publish/unpublish * Fix unit tests * Fix bugs & integration tests * Cleanup action result signatures * Update tests from #11356, new method for saving contentschedule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11290 (for v8)
Details for testing in issue.