-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization add tab text dutch #11346
Localization add tab text dutch #11346
Conversation
Hi there @erikjanwestendorp, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hello @erikjanwestendorp , While checking the language files, I noticed that this same translation was used in the "shortcut" section (cf. en_us.xml file), so I was wondering if you would mind adding it in the "shortcut" section of the "nl.xml" file as well 😁 |
@mikecp Thanks for your review. Of course I want to, just updated the PR 😄 |
Hihi thanks for the update @erikjanwestendorp 👍 Bedankt en tot ziens! |
* Update nl.xml add addTab key * tab to tablad * Add translation to shortcuts sections (cherry picked from commit d222972)
Cherry picked for 8.18 as well 123bcee (hint: easier for us if changes that affect both v8 and v9 start being fixed in v8, since we merge that up regularly). |
Translate "add tab" to dutch (tabblad toevoegen)