Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization add tab text dutch #11346

Merged

Conversation

erikjanwestendorp
Copy link
Contributor

Translate "add tab" to dutch (tabblad toevoegen)

image

@umbrabot
Copy link

umbrabot commented Oct 11, 2021

Hi there @erikjanwestendorp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Oct 11, 2021

Hello @erikjanwestendorp ,
Thanks for this PR, it's always nice helping localize the back-office 👍

While checking the language files, I noticed that this same translation was used in the "shortcut" section (cf. en_us.xml file), so I was wondering if you would mind adding it in the "shortcut" section of the "nl.xml" file as well 😁

@erikjanwestendorp
Copy link
Contributor Author

@mikecp Thanks for your review. Of course I want to, just updated the PR 😄

@mikecp
Copy link
Contributor

mikecp commented Oct 12, 2021

Hihi thanks for the update @erikjanwestendorp 👍
Looking great in the backoffice, so let's merge this and get you qualified for some hacktoberfest swag😉

Bedankt en tot ziens!

@mikecp mikecp merged commit d222972 into umbraco:v9/contrib Oct 12, 2021
nul800sebastiaan pushed a commit that referenced this pull request Oct 26, 2021
* Update nl.xml add addTab key

* tab to tablad

* Add translation to shortcuts sections

(cherry picked from commit d222972)
@nul800sebastiaan
Copy link
Member

Cherry picked for 8.18 as well 123bcee (hint: easier for us if changes that affect both v8 and v9 start being fixed in v8, since we merge that up regularly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants