Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining web.config references in translation files #11344

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

nul800sebastiaan
Copy link
Member

@nul800sebastiaan nul800sebastiaan commented Oct 10, 2021

so it will fallback to the correct English text

Fixes #11191

Since we can't keep #11191 open forever, the suggestion to just fallback to English is a good one, that's been done in this PR.

The following keys were removed in each file, if found in that file:

  • databaseErrorWebConfig
  • databaseNotFound
  • licenseText
  • theEndInstallFailed
  • httpsCheckConfigurationRectifyNotPossible
  • httpsCheckConfigurationCheckResult
  • smtpMailSettingsNotFound
  • smtpMailSettingsHostNotConfigured
  • smtpMailSettingsConnectionFail

Note: this has been a completely manual job since I wanted to prevent reformatting all the xml files, which would be a noisy and unreadable PR. I validated all the XML files in an online validator to make sure I didn't introduce problems by not fully removing the complete <key /> elements.

FWIW, it looks like only the following keys are in active use:

  • httpsCheckConfigurationRectifyNotPossible
  • httpsCheckConfigurationCheckResult
  • smtpMailSettingsNotFound
  • smtpMailSettingsHostNotConfigured
  • smtpMailSettingsConnectionFail

ru errorChangingProviderPassword
@p-m-j
Copy link
Contributor

p-m-j commented Oct 11, 2021

LGTM all parse well.

file missing keys
\Umbraco.Web.UI\umbraco\config\lang\ko.xml 1149
\Umbraco.Web.UI\umbraco\config\lang\he.xml 1148
\Umbraco.Web.UI\umbraco\config\lang\pt.xml 1148
\Umbraco.Web.UI\umbraco\config\lang\it.xml 1062
\Umbraco.Web.UI\umbraco\config\lang\nb.xml 1036
\Umbraco.Web.UI\umbraco\config\lang\ja.xml 945
\Umbraco.Web.UI\umbraco\config\lang\sv.xml 913
\Umbraco.Web.UI\umbraco\config\lang\zh_tw.xml 885
\Umbraco.Web.UI\umbraco\config\lang\zh.xml 878
\Umbraco.Web.UI\umbraco\config\lang\pl.xml 701
\Umbraco.Web.UI\umbraco\config\lang\es.xml 622
\Umbraco.Web.UI\umbraco\config\lang\ru.xml 586
\Umbraco.Web.UI\umbraco\config\lang\de.xml 345
\Umbraco.Web.UI\umbraco\config\lang\fr.xml 227
\Umbraco.Web.UI\umbraco\config\lang\cs.xml 196
\Umbraco.Web.UI\umbraco\config\lang\tr.xml 102
\Umbraco.Web.UI\umbraco\config\lang\cy.xml 96
\Umbraco.Web.UI\umbraco\config\lang\nl.xml 92
\Umbraco.Web.UI\umbraco\config\lang\da.xml 91
\Umbraco.Web.UI\umbraco\config\lang\en_us.xml 14

@p-m-j p-m-j merged commit de12605 into v9/contrib Oct 11, 2021
@p-m-j p-m-j deleted the v9/bugfix/11191 branch October 11, 2021 05:59
@p-m-j p-m-j removed their assignment Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V9: Many (13) references to settings in web.config in en.xml (and translated equivalents)
2 participants