-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifcation when publishing varying culture without domains configured #11328
Merged
Zeegaan
merged 35 commits into
v9/dev
from
v9/feature/add-notifcation-for-url-collision
Oct 15, 2021
Merged
Add notifcation when publishing varying culture without domains configured #11328
Zeegaan
merged 35 commits into
v9/dev
from
v9/feature/add-notifcation-for-url-collision
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't care about dupes
…rl-collision' into v9/feature/add-notifcation-for-url-collision
Zeegaan
reviewed
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few minor things (thank you stylecop)
Rest LGTM 👍
src/Umbraco.Tests.Common/Builders/ContentCultureInfosCollectionBuilder.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.Common/Builders/Interfaces/IBuildContentCultureInfosCollection.cs
Show resolved
Hide resolved
src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/Controllers/ContentControllerTests.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/Controllers/ContentControllerTests.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/Controllers/ContentControllerTests.cs
Show resolved
Hide resolved
src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/Controllers/ContentControllerTests.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.Integration/Umbraco.Web.BackOffice/Controllers/ContentControllerTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikolaj Geisle <[email protected]>
…//github.com/umbraco/Umbraco-CMS into v9/feature/add-notifcation-for-url-collision
Fixed issue where if you were 3 levels deep and published only 1 culture, warning wouldn't fire
With the changes (and the recent bugfix) i tested again and now everything works as it should 👍 Merging 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a notification in the UI as well as a log warning when a content editor creates a piece of multilingual content that has no domain configured for it, this fixes: #10350.
The pattern for what is considered a valid and what is not is a bit weird:
Assume a content type that varies in language A , B, and C the following rules apply as far as I can tell
This is considered valid because only one language is published = we can route this
This is invalid because there's more than one culture published in child node, so we can't route child node
This is valid because somewhere in the ancestor path there's a domain for both languages A and B
This is not valid because there's no domain for language C anywhere
Testing
Please try some different combinations as well, there may have been some "rules" I've missed