-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes the entity containers (folders) created during a package installation in the summary available from the ImportedPackageNotification. #11303
Merged
bergmania
merged 4 commits into
v9/9.0
from
v9/feature/adds-details-of-folders-created-in-package-migration
Oct 6, 2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allation in the summary available from the ImportedPackageNotification.
bergmania
approved these changes
Oct 6, 2021
bergmania
requested changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few breaking changes that needs to be fixed
src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just added a few minor comments!
src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs
Outdated
Show resolved
Hide resolved
bergmania
approved these changes
Oct 6, 2021
bergmania
deleted the
v9/feature/adds-details-of-folders-created-in-package-migration
branch
October 6, 2021 18:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are currently not exposed, and hence not handled by Umbraco Deploy to create the
.uda
files after a package installation. With this information we'll be able to create the schema files on disk for these two and resolve remaining schema mismatch errors following a package installation locally and on Cloud.