Allow opt out of import embedded schema file #11296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime as this runs before the IStartupFilters, and otherwise the static service provider is not available in hosted services. E.g. for migrations
AndyButland
reviewed
Oct 6, 2021
… of https://github.com/umbraco/Umbraco-CMS into v9/bugfix/allow_opt_out_of_import_embedded_schema_file
AndyButland
approved these changes
Oct 6, 2021
bergmania
deleted the
v9/bugfix/allow_opt_out_of_import_embedded_schema_file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration so solutions or packages can opt-out of the import of embedded schema files.
To make this work non-breaking, I had to refactor our initialization of the StaticServiceProvider, as the IStarterFilters are executed after the hosted services. And thereby cannot be used for e.g. migrations.