Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to update user #11270

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

jemayn
Copy link
Contributor

@jemayn jemayn commented Oct 4, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Adds a test that creates a user then updates their name and asserts that the update succeeds.

Question: Should we assert on the content of the xhr call? Or do we just assume it's all good with the success notification in Umbraco? 🙂

Also may make sense to extract the create user stuff in this new test into a cypress command, but had trouble figuring out how to test it works in the commands repo 🤷‍♂️

@umbrabot
Copy link

umbrabot commented Oct 4, 2021

Hi there @jemayn, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nathanwoulfe
Copy link
Contributor

Hey @jemayn, these are great, keep em coming! Re the question on asserting the request content, I could go either way - we're testing the action, which Umbraco tells us has completed successfully by way of the notification, but for extra depth asserting the update exists in the response wouldn't hurt either... Might be a decision from HQ to be applied across the entire test suite?

For now though, this is good to go - new test passes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants