Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Missing JSON Schema Property for RuntimeMinification:Version #11268

Conversation

bergmania
Copy link
Member

@bergmania bergmania commented Oct 4, 2021

Fixes #11188

Fixes Missing JSON Schema Property for RuntimeMinification:Version

Tests

  • Execute the JsonSchema project in release mode and check the generated schema file contains Version and xml docs

Fixes Missing JSON Schema Property for RuntimeMinification:Version
@bergmania bergmania changed the title https://github.com/umbraco/Umbraco-CMS/issues/11188 Fixes Missing JSON Schema Property for RuntimeMinification:Version Oct 4, 2021
@Zeegaan
Copy link
Member

Zeegaan commented Oct 5, 2021

This change was hard to spot manually, luckily a good ol' Json Diff came in handy when testing!

Code looks good to me 💪

@Zeegaan Zeegaan merged commit 846b1c4 into v9/9.0 Oct 5, 2021
@Zeegaan Zeegaan deleted the v9/bugfix/11188_Missing_JSON_Schema_Property_for_Smidge_Version branch October 5, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants