Align template picking more towards the other pickers

[patrickdemooij9]

I noticed that the two template pickers were lacking a bit behind the other ones. I was able to find two template pickers:

• The one used when selecting one or more templates for your document type
• The one used when selecting a master template

And even those two were different from each other. The master template was the cleanest by using the editorService itempicker, but the document type template was still using a modal.

I've used the tree picker editorService to create an view that is more in line with other pickers that we currently have.

Master template:

Document Type:

Some things that might need addressing:

• I now allow you to add a custom picker for the umbGridSelector. I am not sure if this is the correct way of doing it. Open to suggestions here!
• And I think my formatting isn't setup correctly in visual studio. I had a lot of issues with formatting not working that great. I don't know if that reflects in the PR.

Let me know what you think of those changes!

[patrickdemooij9]

I see that my formatting has indeed come through with the PR :( Any way to get the correct formatting for .js files? Then I'll be able to fix the formatting

[umbrabot]

Hi there @patrickdemooij9, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nul800sebastiaan]

@patrickdemooij9 Not to worry, I believe this is actually fixing the wrong old formatting. So your editor (VS/VScode?) has picked up on the .editorconfig file and is applying the rules there.

[patrickdemooij9]

Ah oke @nul800sebastiaan . Then I know that I don't have to fight the formatting! Thanks!

[nul800sebastiaan]

@patrickdemooij9 I had missed that this was targeted at v9! We would love to get this to target v8 first. The problem with making larger changes in the v9 frontend code is that we'll have complex merge conflicts merging upwards from v8 to v9, which we'll still be doing for the foreseeable future. The work on EntityController is definitely valuable though, we will need it when we do the merge from v8 to v9. So could you try this one again on v8 please? I did have a little look if I could do it myself, and all changes in the Web.UI.Client code can be cherry-picked directly. but the EntityController needs a bit of different code though.

I'll close this one for now, but we can refer to it when we merge upwards.
Thanks very much in advance, the changes look good by the way, should be easy to get it merged! 👍