Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change references of Web.config to be appsettings.json #11244

Merged
merged 3 commits into from
Oct 10, 2021
Merged

Change references of Web.config to be appsettings.json #11244

merged 3 commits into from
Oct 10, 2021

Conversation

louisjrdev
Copy link
Contributor

If there's an existing issue for this PR then this fixes #11191

Description

Changes the references to the Web.config to now reference the appsetting.json in the en.xml language file.

@louisjrdev
Copy link
Contributor Author

I am not quite sure how the reference to the Web.config should be handled here:
https://github.com/umbraco/Umbraco-CMS/pull/11244/files#R910

As that config setting does not exist in V9

@umbrabot
Copy link

umbrabot commented Oct 1, 2021

Hi there @louisjrdev, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@louisjrdev louisjrdev marked this pull request as ready for review October 2, 2021 16:33
@mikecp
Copy link
Contributor

mikecp commented Oct 5, 2021

Hello @louisjrdev ,
Thanks for this PR, it is indeed better to refer to the correct files and settings 😀
Would you mind porting those updates to the en_us.xml file as well? This way I can merge the two "default" translation files at once.
Thanks for your help! 👍

@nul800sebastiaan
Copy link
Member

Thanks again @louisjrdev - I've applied the changes to en-US as well and these changes are now merged! 👍

@nul800sebastiaan
Copy link
Member

Hello again @louisjrdev, we had a chat about some of these items and they could be improved some more, a lot of them refer to updating the appsettings.json file but there's MANY place to put config values, so instead of just saying "appsettings.json", we should refer to the config options and the docs for that.

Something like:

your configuration source, for example, appsettings.json (see the documentation)

You can add links if they are in a CDATA block, so for example:

<key alias="scheduledPublishDocumentation"><![CDATA[<a href="https://our.umbraco.com/documentation/Getting-Started/Data/Scheduled-Publishing/#timezones" target="_blank" rel="noopener">What does this mean?</a>]]></key>

Would you be up for going through them one more time in en.xml and en_us.xml to updated where it makes sense?

@nul800sebastiaan
Copy link
Member

FYI: I made the clarifying changes here: #11434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V9: Many (13) references to settings in web.config in en.xml (and translated equivalents)
4 participants