-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change references of Web.config to be appsettings.json #11244
Conversation
I am not quite sure how the reference to the Web.config should be handled here: As that config setting does not exist in V9 |
Hi there @louisjrdev, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hello @louisjrdev , |
Thanks again @louisjrdev - I've applied the changes to en-US as well and these changes are now merged! 👍 |
Hello again @louisjrdev, we had a chat about some of these items and they could be improved some more, a lot of them refer to updating the Something like:
You can add links if they are in a CDATA block, so for example: <key alias="scheduledPublishDocumentation"><![CDATA[<a href="https://our.umbraco.com/documentation/Getting-Started/Data/Scheduled-Publishing/#timezones" target="_blank" rel="noopener">What does this mean?</a>]]></key> Would you be up for going through them one more time in |
FYI: I made the clarifying changes here: #11434 |
If there's an existing issue for this PR then this fixes #11191
Description
Changes the references to the Web.config to now reference the appsetting.json in the en.xml language file.