-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9: Created new system information section in help panel #11230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple of things in the code, I haven't tested anything yet though 😄
src/Umbraco.Tests.UnitTests/Umbraco.Core/Services/UserDataServiceTests.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.UnitTests/Umbraco.Core/Services/UserDataServiceTests.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.UnitTests/Umbraco.Core/Services/UserDataServiceTests.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.AcceptanceTest/cypress/integration/Tour/systemInformation.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Tests.AcceptanceTest/cypress/integration/Tour/systemInformation.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.BackOffice/Controllers/CurrentUserController.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikolaj Geisle <[email protected]>
Co-authored-by: Mole <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
take 1000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, and all tests are passing 🎉, let's get this merged
src/Umbraco.Web.BackOffice/Controllers/CurrentUserController.cs
Outdated
Show resolved
Hide resolved
Looks great 👍 Since there is already some information about the server, wouldn't it make sense to also include the machine name? I know there should ever only be a single master server in a load balanced setup, but having the machine there would help confirm that the user is hitting the right server. |
Hi @abjerner and thanks for the suggestion 👍 You're free to add this to the user Dashboard though, here's a PR that allows for custom dashboards: Thanks again for the comment! 🚀 |
Notes
How to test
npm install
&npm run build
platform.service.js
(either withnpm run dev
already running, or rebuilding the client project withnpm install
&npm run build