v9 Fix build required before initial publish

[p-m-j]

With huge thanks to the comments in dotnet/sdk#960

[OzoneNZ]

Any chance #11215 can be resolved in this PR too?

Believe it's just a case of updating the CopyUmbracoAssets target to specify BeforeTargets="Rebuild;Build"

[p-m-j]

@OzoneNZ potentially, although this is slightly experimental, I'm hoping we can resolve the build+publish problem in a nicer way then I have here so it may make sense to resolve #11215 elsewhere with higher priority as it sounds more problematic.

[OzoneNZ]

@OzoneNZ potentially, although this is slightly experimental, I'm hoping we can resolve the build+publish problem in a nicer way then I have here so it may make sense to resolve #11215 elsewhere with higher priority as it sounds more problematic.

No worries, cheers for explaining - have opened another PR to resolve that issue

[p-m-j]

Do believe a5c5f69 will also nicely close #11215

[p-m-j]

related reading
NuGet/Home#6659
NuGet/Home#4942

[OzoneNZ]

@p-m-j I have a similar issue blocking our move to V9, where the first fresh Build of a 9.0.1 project does not copy the umbraco folder into bin

Only the second Build run actually copies the umbraco folder into bin, shown below with a fresh/empty 9.0.1 project

I suspect this is something that also requires changes to Umbraco.Cms.StaticAssets.targets but I've been unable to figure out what is causing the files not to be included on first build

Sounds very similar to this issue however: https://stackoverflow.com/a/606658

Also note that the issue remains even when applying this PR patch

[OzoneNZ]

Managed to solve the above issue with some changes to build/templates/UmbracoProject/UmbracoProject.csproj

I think what's going on is that msbuild is evaluating the line below too early, prior to the execution of the CopyUmbracoAssets target which copies the static assets, so msbuild thinks there is nothing to include:

<Content Include="umbraco/**" CopyToOutputDirectory="Always" />

Which would explain why the second-time build has no issues copying the files, because they exist from the very start having been copied during the first build attempt - the stack overflow link above confirms this msbuild behaviour

My workaround is to wrap the <Content Include="..."> within a target that is guaranteed to execute after CopyUmbracoAssets:

<Target Name="IncludeUmbracoAssets" AfterTargets="CopyUmbracoAssets">
  <ItemGroup>
    <Content Include="umbraco/**" CopyToOutputDirectory="Always" CopyToPublishDirectory="Always" />
  </ItemGroup>
</Target>

[p-m-j]

Yep that's annoying, I called it quits when the published output was sorted, will have a look later on in the week.