Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multi URL Picker in Block List Editor #11157

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

madsrasmussen
Copy link
Contributor

fixes #11100

Properties from tabs were rendered twice. One for direct properties for a tab and one for groups because they are part of the groups' array. This PR prevents a group to be rendered in the groups' array if it is a "tab".

Multi URL Picker listens for a form submit event and sets the value based on a render value. Because the property is rendered twice, when it is a direct property on a tab, it resets its own value.

The reset only happens in the Block List editor because of how it syncs its values. I have added the fix to the content, media, and members section for performance reasons. We don't want more properties in the DOM than needed.

How to test:

  • See the issue for testing instructions for the bug.
  • Please also do some "general" testing of tabs and groups in content, media and member sections and this changes how we render them.

@Zeegaan
Copy link
Member

Zeegaan commented Sep 22, 2021

Tested this and it works great! 👍

Code looks good to my untrained frontend eyes 👓

@Zeegaan Zeegaan merged commit ef7fe70 into v8/dev Sep 22, 2021
@Zeegaan Zeegaan deleted the v8/bugfix/11100-fix-multi-url-picker-in-block-list branch September 22, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants