Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #11150 V9: MediaPicker3 casing incorrect #11154

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fixes #11150 V9: MediaPicker3 casing incorrect #11154

merged 1 commit into from
Sep 21, 2021

Conversation

nul800sebastiaan
Copy link
Member

Fixes #11150 V9: MediaPicker3 casing incorrect

@nul800sebastiaan
Fixes #11150
80386db 
V9: MediaPicker3 casing incorrect
@nul800sebastiaan nul800sebastiaan linked an issue Sep 21, 2021 that may be closed by this pull request
V9: MediaPicker3 casing incorrect #11150
Closed
@nul800sebastiaan nul800sebastiaan mentioned this pull request Sep 21, 2021
Closed
AndyButland
AndyButland approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@AndyButland AndyButland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. I don't have a handy Linux setup to test yet, but can confirm this now matches the file path on disk.

@bergmania
Copy link
Member

Looks correct.. Apparently WSL2 is not case sensitive, so my test was useless 🤦

@bergmania bergmania merged commit 31034c7 into v9/dev Sep 21, 2021
@bergmania bergmania deleted the v9/bugfix/11150 branch September 21, 2021 17:33
@bergmania
Copy link
Member

FYI you can enable case sensitive directories in Windows 10.
It works on a per directory basic, but can be executed recursively in subfolders using this PS command

(Get-ChildItem -Recurse -Directory).FullName | ForEach-Object {fsutil.exe file setCaseSensitiveInfo $_ enable}

Thereby it is possible to test casing issues on windows 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyButland AndyButland AndyButland approved these changes

Assignees
No one assigned
Labels
project/v9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V9: MediaPicker3 casing incorrect
3 participants
@nul800sebastiaan @bergmania @AndyButland